Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgrade grpc to fix regression #14065

Merged
merged 3 commits into from
Sep 6, 2024
Merged

fix: downgrade grpc to fix regression #14065

merged 3 commits into from
Sep 6, 2024

Conversation

trevorwhitney
Copy link
Collaborator

What this PR does / why we need it:

The upgrade to GRPC caused the categorized labels header to put binary encoded data in the response. This downgrades back to 1.65

Which issue(s) this PR fixes:
Fixes #14053

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@trevorwhitney trevorwhitney requested a review from a team as a code owner September 5, 2024 22:23
@trevorwhitney trevorwhitney added type/bug Somehing is not working as expected product-approved backport k218 and removed size/M labels Sep 5, 2024
@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

2 similar comments
@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

@trevorwhitney trevorwhitney merged commit 8c38d46 into main Sep 6, 2024
60 checks passed
@trevorwhitney trevorwhitney deleted the downgrade-grpc branch September 6, 2024 20:06
grafanabot pushed a commit that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend protobuf encoding breaks X-Loki-Response-Encoding-Flags: categorize-labels header
3 participants